-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack Manager #457
Draft
carymrobbins
wants to merge
77
commits into
master
Choose a base branch
from
stack-manager
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Stack Manager #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale here is that package.yaml files can get quite complex, specifically in regards to anchors. Instead, we should just call out to 'stack build --dry-run' to generate the cabal files, which will also verify that our build configuration is valid, then we can just parse each cabal file into a PackageConfig.
…r to get around needing an Application in the externalSystem
… modifying stack.yaml
…to-import feature
Was previously wrapped in an erroneous 'getPkgs' call which would always be None if the ghc-pkg cache had not been previously loaded.
It seems like this check should be pointless since the file 'f' in question was found in the module name index.
…dule" This reverts commit e8c3fe9.
In a previous commit, we changed HaskellBuildSettings to no longer auto-guess the exe if it was not set. This broke some assumptions made by our new project wizard in HaskellModuleBuilder. Fixed this by doing the guessing manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
stack
framework integration.